Skip to content

PHPC-1046: Use authSource URI option to specify $external #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Nov 20, 2017

https://jira.mongodb.org/browse/PHPC-1046

@derickr: This is the same change I had you add in #672. I noticed this was failing since PHPC 1.3.0 when we bumped to libmongoc 1.8.0. The relevant change was CDRIVER-2190 from libmongoc 1.7.0 (which we never bundled with directly).

I'd like to fix it in 1.3.x as I noticed the failure after bumping the 1.8.2 in #674.

@jmikola jmikola requested a review from derickr November 20, 2017 22:48
Copy link
Contributor

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmikola jmikola merged commit aea5584 into v1.3 Nov 21, 2017
jmikola added a commit that referenced this pull request Nov 21, 2017
@jmikola jmikola deleted the phpc-1046 branch November 21, 2017 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants